Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(streamx): fix streamx Recv timeout unit test #1676

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

DMwangnima
Copy link
Contributor

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

test(stream): 修复 streamx Recv 超时的测试用例

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
error case: https://github.com/cloudwego/kitex/actions/runs/12766989287/job/35584452262?pr=1674
Injecting too short a timeout into the ctx before creating the stream can potentially time out when doing service discovery:
image
zh(optional):
报错 case: https://github.com/cloudwego/kitex/actions/runs/12766989287/job/35584452262?pr=1674
在创建 stream 前往 ctx 中注入过短的 timeout,有可能在进行服务发现时超时:
image

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners January 15, 2025 06:07
@DMwangnima DMwangnima force-pushed the test/fix_ttstream_test branch from fe05dac to 951eb1a Compare January 15, 2025 06:08
@xiaost xiaost force-pushed the test/fix_ttstream_test branch from 951eb1a to 140698e Compare January 15, 2025 06:39
@DMwangnima DMwangnima merged commit 2f49a5f into cloudwego:develop Jan 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants